kasjer commented on code in PR #3300: URL: https://github.com/apache/mynewt-core/pull/3300#discussion_r1740972078
########## net/cellular/blues/pkg.yml: ########## @@ -0,0 +1,27 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +pkg.name: net/cellular/blues +pkg.description: Blues Wireless Note-c API port +pkg.author: "Apache Mynewt <[email protected]>" +pkg.homepage: "http://mynewt.apache.org/"; +pkg.keywords: +pkg.deps: + - "@apache-mynewt-core/kernel/os" + - "@apache-mynewt-core/sys/shell" Review Comment: note-c repository has flat structure where source files and include files are at the top of git repository. ```yml pkg.source_dirs: - "@blues-note-c/." ``` includes files from this repository without need to have `src` folder that is common for mynewt. Section: ```yml pkg.include_dirs: - "@blues-note-c/." ``` makes does same for include directories so mynewt default `include` folder is not needed. Then if you have this, there is no need to have include files renamed. Application code should then include original file names that are visible in repository. Please add additional line to pkg.yml: ```yml pkg.type: sdk ``` that should make application aware of include files location in remote repository. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
