kasjer commented on code in PR #3300: URL: https://github.com/apache/mynewt-core/pull/3300#discussion_r1741858085
########## net/cellular/blues/pkg.yml: ########## @@ -0,0 +1,27 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +pkg.name: net/cellular/blues +pkg.description: Blues Wireless Note-c API port +pkg.author: "Apache Mynewt <d...@mynewt.apache.org>" +pkg.homepage: "http://mynewt.apache.org/"; +pkg.keywords: +pkg.deps: + - "@apache-mynewt-core/kernel/os" + - "@apache-mynewt-core/sys/shell" Review Comment: Your branch with latest commit has two copies of repository that should not be there at all. First commit that you make should have just `net/cellular/blues/pkg.yml`. After you add this, you should do ```sh newt upgrade ``` This should download note-c repository and their files should be in `repos/blue-note-c`. Then your application should be able to access those files without need to change files names for included files and without local copies of their files. You can use this PR if you want. At this point proffered way would be to force push your branch to have just 2 commits. One with repository package file and second with application code in apps/ folder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
