andrzej-kaczmarek commented on code in PR #1974:
URL: https://github.com/apache/mynewt-nimble/pull/1974#discussion_r1961336814
##########
nimble/controller/include/controller/ble_phy.h:
##########
@@ -88,14 +92,11 @@ int ble_phy_init(void);
int ble_phy_setchan(uint8_t chan, uint32_t access_addr, uint32_t crcinit);
uint8_t ble_phy_chan_get(void);
-#if MYNEWT_VAL(BLE_PHY_VARIABLE_TIFS)
-/* Set T_ifs time for next transition */
-void ble_phy_tifs_set(uint16_t tifs);
-#endif
+/* Set T_ifs for the next transition */
+void ble_phy_tifs_set(uint16_t usecs, uint8_t anchor);
Review Comment:
this is no longer needed (?)
##########
nimble/controller/include/controller/ble_phy.h:
##########
@@ -88,14 +92,11 @@ int ble_phy_init(void);
int ble_phy_setchan(uint8_t chan, uint32_t access_addr, uint32_t crcinit);
uint8_t ble_phy_chan_get(void);
-#if MYNEWT_VAL(BLE_PHY_VARIABLE_TIFS)
-/* Set T_ifs time for next transition */
-void ble_phy_tifs_set(uint16_t tifs);
-#endif
+/* Set T_ifs for the next transition */
+void ble_phy_tifs_set(uint16_t usecs, uint8_t anchor);
-/* Set T_ifs for tx-tx transitions. Anchor is 0 for start of previous PDU,
- * non-zero for end of PDU */
-void ble_phy_tifs_txtx_set(uint16_t usecs, uint8_t anchor);
+/* Set direction of the next transition */
+void ble_phy_transition_set(uint8_t trans, uint8_t anchor, uint16_t usecs);
Review Comment:
I wonder if we should perhaps merge `trans` and `anchor` to a single
parameter
standard tifs transitions would be called as they are now, but add 2
transitions that anchor at the beginning of pdu, smth like
`BLE_PHY_TRANSITION_TO_TX_SUB` -> `sub` is short of 'subevent' as this is where
it will be used
@sjanc ^^
##########
nimble/drivers/nrf5x/src/ble_phy.c:
##########
@@ -2347,8 +2454,21 @@ ble_phy_rfclk_disable(void)
}
void
-ble_phy_tifs_txtx_set(uint16_t usecs, uint8_t anchor)
+ble_phy_transition_set(uint8_t trans, uint8_t anchor, uint16_t usecs)
+{
+ g_ble_phy_data.phy_transition = trans;
+ g_ble_phy_data.tifs_anchor = anchor;
+ g_ble_phy_data.tifs_usecs = usecs ? usecs : BLE_LL_IFS;
+}
+
+void
+ble_phy_wfr_set(uint16_t usecs)
+{
+ g_ble_phy_data.wfr_usecs = usecs;
+}
+
+void
+ble_phy_fast_transition_enable(void)
Review Comment:
what is fast transition?
##########
nimble/drivers/nrf5x/src/ble_phy.c:
##########
@@ -1798,6 +1883,14 @@ ble_phy_set_txend_cb(ble_phy_tx_end_func txend_cb, void
*arg)
g_ble_phy_data.txend_arg = arg;
}
+void
+ble_phy_set_rxend_cb(ble_phy_rx_end_func rxend_cb, void *arg)
+{
+ /* Set transmit end callback and arg */
Review Comment:
'receive'
what is the purpose of this callback? it doesn't seem to be used anywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
