sjanc commented on code in PR #1974: URL: https://github.com/apache/mynewt-nimble/pull/1974#discussion_r1961385805
########## nimble/controller/include/controller/ble_phy.h: ########## @@ -88,14 +92,11 @@ int ble_phy_init(void); int ble_phy_setchan(uint8_t chan, uint32_t access_addr, uint32_t crcinit); uint8_t ble_phy_chan_get(void); -#if MYNEWT_VAL(BLE_PHY_VARIABLE_TIFS) -/* Set T_ifs time for next transition */ -void ble_phy_tifs_set(uint16_t tifs); -#endif +/* Set T_ifs for the next transition */ +void ble_phy_tifs_set(uint16_t usecs, uint8_t anchor); -/* Set T_ifs for tx-tx transitions. Anchor is 0 for start of previous PDU, - * non-zero for end of PDU */ -void ble_phy_tifs_txtx_set(uint16_t usecs, uint8_t anchor); +/* Set direction of the next transition */ +void ble_phy_transition_set(uint8_t trans, uint8_t anchor, uint16_t usecs); Review Comment: yeah, but I'd call it subevent for clarity -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
