kasjer commented on code in PR #3365:
URL: https://github.com/apache/mynewt-core/pull/3365#discussion_r1980929553


##########
sys/log/full/src/log_shell.c:
##########
@@ -251,6 +276,29 @@ shell_log_dump_cmd(int argc, char **argv)
             continue;
         }
 
+#if MYNEWT_VAL(LOG_FCB_BOOKMARKS)
+        if (dump_bmarks) {
+            bmarks = log_fcb_get_bmarks(log, &bmarks_size);
+            for (i = 0; i < bmarks_size; i++) {
+#if MYNEWT_VAL(LOG_FCB)
+                console_printf("%u: index:%lu entry: %x fa: %x fe_elem_off: 
%lx\n", i,
+                               bmarks[i].lfb_index,
+                               (uintptr_t)&bmarks[i].lfb_entry,
+                               (uintptr_t)bmarks[i].lfb_entry.fe_area,

Review Comment:
   Updated version will not compile due `.` instead of `->`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to