kasjer commented on code in PR #3365:
URL: https://github.com/apache/mynewt-core/pull/3365#discussion_r1981562651
##########
sys/log/full/src/log_fcb.c:
##########
@@ -209,13 +215,21 @@ log_fcb_start_append(struct log *log, int len, struct
fcb_entry *loc)
struct fcb_log *fcb_log;
struct flash_area *old_fa;
int rc = 0;
+#if MYNEWT_VAL(LOG_FCB_SECTOR_BOOKMARKS)
+ int active_sector_cnt = 0;
Review Comment:
variable name `active_sector_cnt` is misleading, same applies to later
comment
value stored in variable is number of log entries in a sector that is
currently active (have some space left).
I think that f_active_id could be used instead to determine that sector
changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
