arusinha commented on a change in pull request #2222:
URL: https://github.com/apache/netbeans/pull/2222#discussion_r458712945
##########
File path:
java/java.completion/src/org/netbeans/modules/java/completion/JavaCompletionTask.java
##########
@@ -3930,6 +4136,8 @@ public boolean accept(Element e, TypeMirror t) {
}
};
for (TypeElement e :
controller.getElementUtilities().getGlobalTypes(acceptor)) {
+ if (e.getQualifiedName().toString().equals(JAVA_LANG_RECORD) &&
env.getController().getSourceVersion().compareTo(SOURCE_VERSION_RELEASE_14) <
0)
Review comment:
If I don't add the check , 'Record' entry need to be added in old golden
files (roughly 65 files) otherwise existing test-cases will fail with nb-javac
for 14
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
