lahodaj commented on a change in pull request #2222:
URL: https://github.com/apache/netbeans/pull/2222#discussion_r459245701
##########
File path:
java/java.completion/src/org/netbeans/modules/java/completion/JavaCompletionTask.java
##########
@@ -3930,6 +4136,8 @@ public boolean accept(Element e, TypeMirror t) {
}
};
for (TypeElement e :
controller.getElementUtilities().getGlobalTypes(acceptor)) {
+ if (e.getQualifiedName().toString().equals(JAVA_LANG_RECORD) &&
env.getController().getSourceVersion().compareTo(SOURCE_VERSION_RELEASE_14) <
0)
Review comment:
Sorry, I am unclear which files - the code completion tests run and pass
on JDK 14 without nb-javac, the golden files have been updated some time ago. I
believe files like
".../JavaCompletionTaskTest/14/initBlockTypesAndLocalMembers.pass" have been
specifically added so that the tests would pass on JDK 14. Not sure if nb-javac
should change anything here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
