matthiasblaesing commented on a change in pull request #2475:
URL: https://github.com/apache/netbeans/pull/2475#discussion_r511583957
##########
File path:
java/dbschema/src/org/netbeans/modules/dbschema/jdbcimpl/SchemaElementImpl.java
##########
@@ -592,18 +592,18 @@ private void initViews(ConnectionProvider cp, LinkedList
views, DDLBridge bridge
rset =
bridge.getDriverSpecification().getRow();
//test references between two schemas
- c1 = (String) rset.get(new Integer(1));
- s1 = (String) rset.get(new Integer(2));
- c2 = (String) rset.get(new Integer(5));
- s2 = (String) rset.get(new Integer(6));
+ c1 = rset.get(new Integer(1));
Review comment:
If we do we'll have a bigger problem. The primitive wrapper constructors
will go away (they are deprecated for removal), so we need to get rid of them.
To my knowledge there is only one valid reason to use the constructors: You
want an object, that you can synchronize on, that is not shared with others.
But that is also flawed and will break in the future, when the primitive
wrappers will be turned into value base objects, that don't have identity and
don't hold a monitor.
TL;DR: `c1 = rset.get(new Integer(1));` should be `c1 = rset.get(1);`
But that might be worth fixing in another iteration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
