lkishalmi commented on a change in pull request #2475:
URL: https://github.com/apache/netbeans/pull/2475#discussion_r512229222
##########
File path:
java/dbschema/src/org/netbeans/modules/dbschema/jdbcimpl/SchemaElementImpl.java
##########
@@ -592,18 +592,18 @@ private void initViews(ConnectionProvider cp, LinkedList
views, DDLBridge bridge
rset =
bridge.getDriverSpecification().getRow();
//test references between two schemas
- c1 = (String) rset.get(new Integer(1));
- s1 = (String) rset.get(new Integer(2));
- c2 = (String) rset.get(new Integer(5));
- s2 = (String) rset.get(new Integer(6));
+ c1 = rset.get(new Integer(1));
Review comment:
Ok, then let's have this in.
I've checked the code there are more than 5000 instances of new Integer,
there also there are a few Long-s, Byte, Short-s and Chars as well. So that
would be probably a few additional PR-s
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
