errael commented on pull request #2482: URL: https://github.com/apache/netbeans/pull/2482#issuecomment-721242095
@matthiasblaesing > what is wrong with the "draw till next character" approach? Referring to that suggestion, I said "I agree that this should fix it", Comment in https://github.com/apache/netbeans/pull/2482#issuecomment-720126563 . Don't let me dissuade you from opening a PR to replace this one.I don't particularly like adding another call to modelToView, since it's typically not needed. But I do have a tendency to pre/over-optimize. Simply making it wider, without the second modelToView call, fixing the vast majority of cases _and_ an API for those more adventurous souls is probably the right thing, option 3 in https://github.com/apache/netbeans/pull/2482#issuecomment-719949269 > The API addition be it necessary or not, will not fix the existing users. Recall that my **goal with this PR was to sneak something into 12.2 that would be "zero risk"**, no change to current behavior; that ship has passed And I've said "If in the fullness of time there's an accepted solution..." in https://github.com/apache/netbeans/pull/2482#issuecomment-717312901 > This is the code I used to see what Swing reports for `modelToView` I've mentioned several times that NetBeans uses it's own ViewHierarchy. What Swing reports is not relevant to this discussion. I polished up the PR so it was proper. _I'm OK if it is not merged._ I have a workaround. I'm planning to try some experiments with my caret (based on BaseCaret), like drawing a circle around the character and see if there are other problems. Just crazy stuff that wouldn't work by simply widening the bounding box. This is discussed in https://github.com/apache/netbeans/pull/2482#issuecomment-719949269 The caret drawing problem in the standard NetBeans caret EditorCaret, as discussed in this PR, are probably more important than this. I'll add the EditorCaret notes to the issue right now, before I forget again. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
