matthiasblaesing commented on a change in pull request #3013:
URL: https://github.com/apache/netbeans/pull/3013#discussion_r656487013
##########
File path: java/maven/nbproject/project.xml
##########
@@ -369,7 +369,7 @@
<compile-dependency/>
<run-dependency>
<release-version>1</release-version>
- <specification-version>1.4</specification-version>
+ <specification-version>1.45</specification-version>
Review comment:
Looks like a large jump, should this be `1.5`?
##########
File path: ide/xml.xam/src/org/netbeans/modules/xml/xam/AbstractModel.java
##########
@@ -179,12 +180,22 @@ public State getState() {
return status;
}
+ @Override
+ public String getStatusMessage() {
+ return statusMessage;
+ }
+
protected void setState(State s) {
+ setState(s, null);
+ }
+
+ protected void setState(State s, String message) {
if (s == status) {
return;
}
State old = status;
status = s;
+ statusMessage = message;
PropertyChangeEvent event =
Review comment:
`statusMessage`is a different property, so I would expect both
`PropertyChangeEvents` to be fired.
##########
File path: ide/xml.xam/src/org/netbeans/modules/xml/xam/AbstractModel.java
##########
@@ -179,12 +180,22 @@ public State getState() {
return status;
}
+ @Override
+ public String getStatusMessage() {
+ return statusMessage;
+ }
+
protected void setState(State s) {
+ setState(s, null);
+ }
+
+ protected void setState(State s, String message) {
Review comment:
The `if` construct in line 193 (new) looks wrong - the state could stay
the same, but the message could change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
