sdedic commented on a change in pull request #3013:
URL: https://github.com/apache/netbeans/pull/3013#discussion_r666694813
##########
File path: ide/xml.xam/src/org/netbeans/modules/xml/xam/AbstractModel.java
##########
@@ -179,12 +180,22 @@ public State getState() {
return status;
}
+ @Override
+ public String getStatusMessage() {
+ return statusMessage;
+ }
+
protected void setState(State s) {
+ setState(s, null);
+ }
+
+ protected void setState(State s, String message) {
if (s == status) {
Review comment:
`statusMessage` does not behave as a property; can be only updated
during a state change ... which can be reasonable. Pls. document the behaviour,
`status` name looks like property updatable even during a single state.
##########
File path: java/maven/nbproject/project.xml
##########
@@ -369,7 +369,7 @@
<compile-dependency/>
<run-dependency>
<release-version>1</release-version>
- <specification-version>1.4</specification-version>
+ <specification-version>1.45</specification-version>
Review comment:
No - see [change in XAM in this
PR](https://github.com/apache/netbeans/pull/3013/files#diff-d4cbe9616caee5c9e8a0b7766f54bf932349c61e0bcc223082bbebfa3c117ae2R24)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
