mbien commented on a change in pull request #3410:
URL: https://github.com/apache/netbeans/pull/3410#discussion_r779110981
##########
File path: nbbuild/cluster.properties
##########
@@ -299,8 +298,7 @@ nb.cluster.platform=\
spi.actions,\
spi.quicksearch,\
templates,\
- templatesui,\
- uihandler
Review comment:
i can't explain why its getting loaded on startup.
```java
void setEnabled(boolean enabled) {
/* #13647: actually can happen if loading of bootstrap modules is
rolled back: */
if (isFixed() && ! enabled) throw new IllegalStateException("Cannot
disable a fixed module: " + this); // NOI18N
if (!this.isEnabled()) {
Dependency[] deps = this.data.getDependencies();
if(deps != null) {
for (Dependency dependency : deps) {
if (dependency.getName().contains("uihandler") ||
dependency.getName().contains("exceptionreporter")) {
System.out.println(this.data.getCodeName()+"
(autoload: "+isAutoload()+", eager: "+isEager()+")");
System.out.println("depends on: "+dependency);
System.out.println();
}
}
}
}
this.enabled = enabled;
}
```
results in:
```
org.netbeans.modules.uihandler (autoload: false, eager: false)
depends on: module org.netbeans.lib.uihandler > 1.37
org.netbeans.modules.uihandler.exceptionreporter (autoload: false, eager:
false)
depends on: module org.netbeans.modules.uihandler > 2.0
org.netbeans.modules.bugzilla.exceptionreporter (autoload: false, eager:
true)
depends on: module org.netbeans.lib.uihandler > 1.37
```
nothing depends on the uihandler modules which is also autoloading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
