matthiasblaesing commented on pull request #3594:
URL: https://github.com/apache/netbeans/pull/3594#issuecomment-1039473080
@nbauma109 this change causes a problem in other unittests. I had a quick
look at it and indeed the problem is locally reproduceable. It seems, that the
unittest relied on original document returned. My gut feeling is, that the
indention seems to be sane after the change. This was the change needed:
```diff
# This patch file was generated by NetBeans IDE
# It uses platform neutral UTF-8 encoding and \n newlines.
---
a/java/java.source.base/test/unit/src/org/netbeans/api/java/source/gen/CompilationUnitTest.java
+++
b/java/java.source.base/test/unit/src/org/netbeans/api/java/source/gen/CompilationUnitTest.java
@@ -1280,7 +1280,7 @@
" public I(java.util.Collection c) {\n" +
" super(c);\n" +
" }\n" +
- " \n" +//XXX
+ " \n" +//XXX
"}\n";
JavaSource javaSource = JavaSource.create(cpInfo,
FileUtil.toFileObject(testFile));
@@ -1309,7 +1309,7 @@
result.commit();
String res = TestUtilities.copyFileToString(new
File(getDataDir().getAbsolutePath() + "/zoo/I.java"));
//System.err.println(res);
- assertEquals(res, golden1);
+ assertEquals(golden1, res);
}
String getGoldenPckg() {
```
You can run the failing unittest locally:
```bash
ant -f java/java.source.base/ test
```
The failure can be found in
java/java.source.base/build/test/unit/results/TEST-org.netbeans.api.java.source.gen.CompilationUnitTest.xml
(or by running the unittest in the IDE).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
