jlahoda commented on pull request #3594:
URL: https://github.com/apache/netbeans/pull/3594#issuecomment-1046527563


   So, I believe the reason for the failing `CompilationUnitTest.java` is 
because, when the Language is installed, reformatter runs when the file is 
created. I see the `PartialReparseTest` is failing again, and the reason is 
probably similar (reformatter changes the code, so that original positions are 
no longer reasonable and the test modifies wrong parts of the code). Any other 
test that is failing?
   
   I believe NB is normally finding the Languages using an implementation of 
`org.netbeans.spi.lexer.LanguageProvider` (the NB implementation will look the 
Language in a MimeLookup, but I believe it can get the Language anywhere). I 
wonder if that would be a viable alternative?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to