mbien commented on code in PR #4142:
URL: https://github.com/apache/netbeans/pull/4142#discussion_r888448831
##########
java/java.lsp.server/test/unit/src/org/netbeans/modules/java/lsp/server/protocol/ServerTest.java:
##########
@@ -3228,7 +3228,12 @@ public CompletableFuture<ApplyWorkspaceEditResponse>
applyEdit(ApplyWorkspaceEdi
@Override
public CompletableFuture<List<QuickPickItem>>
showQuickPick(ShowQuickPickParams params) {
- return
CompletableFuture.completedFuture(params.getItems().size() > 2 ?
params.getItems().subList(0, 2) : params.getItems());
+ List<QuickPickItem> selection = params.getItems().stream()
+ .filter((i) -> i.getLabel().equals("f1.chars():
IntStream") || i.getLabel().equals("f1.codePoints(): IntStream"))
+ .sorted((i1, i2) ->
i1.getLabel().compareTo(i2.getLabel()))
+ .collect(Collectors.toList());
+ assertEquals(2, selection.size());
+ return CompletableFuture.completedFuture(selection);
Review Comment:
Hi @sdedic, I have a question.
`ServerTest.testSourceActionDelegateMethod()` assumes that the items are
served in a certain order. This PR here however adds an optimization which
would return a random order due to the fact that
`ElementUtilities.getMembers()` uses HashMaps internally.
The problem is that I don't know the requirements.
- is it ok to change this test
- or does getMembers() have to return a certain order
- or does the LSP code have to sort the results somewhere, so the correct
way would be to revert this test and fix it in LSP code
interestingly this was the only test which fails even though the order of
`getMembers`, `getLocalMembersAndVars`, `getLocalVars` and, `getGlobalTypes`
return values changed. NB itself does display the choices in the same sorted
order as before too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
