sdedic commented on code in PR #4142:
URL: https://github.com/apache/netbeans/pull/4142#discussion_r908086654
##########
java/java.lsp.server/test/unit/src/org/netbeans/modules/java/lsp/server/protocol/ServerTest.java:
##########
@@ -3228,7 +3228,12 @@ public CompletableFuture<ApplyWorkspaceEditResponse>
applyEdit(ApplyWorkspaceEdi
@Override
public CompletableFuture<List<QuickPickItem>>
showQuickPick(ShowQuickPickParams params) {
- return
CompletableFuture.completedFuture(params.getItems().size() > 2 ?
params.getItems().subList(0, 2) : params.getItems());
+ List<QuickPickItem> selection = params.getItems().stream()
+ .filter((i) -> i.getLabel().equals("f1.chars():
IntStream") || i.getLabel().equals("f1.codePoints(): IntStream"))
+ .sorted((i1, i2) ->
i1.getLabel().compareTo(i2.getLabel()))
+ .collect(Collectors.toList());
+ assertEquals(2, selection.size());
+ return CompletableFuture.completedFuture(selection);
Review Comment:
Please keep the changes in the test. The importance of the order **is not
mentioned** in the Javadoc anywhere and as you noted, E.U. returns `Iterable`
= no guarantees. It's good not to break the de-facto behaviour
(`LinkedHashMap`), but the test should stick to the API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
