mbien commented on PR #4142: URL: https://github.com/apache/netbeans/pull/4142#issuecomment-1168488836
> BTW the usage of `LinkedHashMap` does not entirely preserve the orignal order. Originally, elements that were not `isHidden` accumulated in a list in the order of element encounter. Now, **simpleName** order is preserved, but since Elements are assigned into individual named buckets, the relative order of (i.e.) 2nd or later references to names `foo` and `bar` may change their relative positions in the final result. Yes, thats why I was reluctant to use a linked map right away. We would have to use two data structures, one List like in the original version, and the Map from the new version just for the visibility checks. Only the list is returned. I hope this would work without much overhead - but having redundant data structures is always ugly. I wished this wouldn't be needed and we could just return the list in any order :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
