eirikbakke commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1170159721

   > Getting adequate contrast with Eirik's request to use @background for 
selected tab means we have to go quite dark (original image used 
@componentBackground). Still, I think it is probably better this way around. 
   
   Yes, I think this is good!
   
   > Or now too close to editor background?
   That's fine; the editor background is not adjacent to the tab background.
   
   As commented in-code, you can also drop the separator line after the last 
tab:
   
   <img width="353" alt="seplast" 
src="https://user-images.githubusercontent.com/886243/176480270-6364b2c9-7d27-4ceb-a674-bf5b3bea9e14.png";>
   
   > Moved inactive underline colour back to what it was in first image
   
   Wait, why did this grey line on top of the active-but-unfocused tab pop back 
in? See my earlier comment about blue and grey being indistinguishable in 
peripheral vision.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to