neilcsmith-net commented on code in PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#discussion_r911214196
##########
platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/ui/FlatEditorTabCellRenderer.java:
##########
@@ -219,11 +222,17 @@ private void paintInteriorAtScale1x(Graphics2D g,
Component c, int width, int he
if (selected && underlineHeight > 0) {
// paint underline if tab is selected
int underlineHeight = (int)
Math.round(FlatEditorTabCellRenderer.underlineHeight * scale);
- g.setColor(ren.isActive() ? underlineColor :
inactiveUnderlineColor);
- if (underlineAtTop)
+ if (underlineAtTop) {
+ g.setColor(contentBorderColor);
+ int borderWidth = (int) (1 * scale);
+ g.fillRect(0, 0, borderWidth, height);
+ g.fillRect(width - tabSeparatorWidth - borderWidth, 0,
borderWidth, height);
+ g.setColor(ren.isActive() ? underlineColor :
inactiveUnderlineColor);
g.fillRect(0, 0, width - tabSeparatorWidth,
underlineHeight);
Review Comment:
I reverted the border colour change, and it looks odd without this. The
"underline" sits on the content border now either way. I think it's needed for
consistency, and I'd like this to work standalone if merged. You can enhance or
remove as needed then, but this is a more sensible default IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
