neilcsmith-net commented on code in PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#discussion_r1016647620
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
Review Comment:
Should this default to 1?
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
Review Comment:
The default template needs to be software neutral. Which fields are
required? If we need a license field, it needs to be an option, same with URL.
If group needed, can it be the same as the .desktop file group?
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
+BuildArch: ${RPM_ARCH}
+Packager: ${RPM_MAINTAINER}
+Vendor: Apache NetBeans
+Requires: java >= 11
Review Comment:
Shouldn't be any requires. Package with runtime has Java. Package without
should be covered by Recommends.
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
+BuildArch: ${RPM_ARCH}
+Packager: ${RPM_MAINTAINER}
+Vendor: Apache NetBeans
Review Comment:
If vendor needed, possibly default to same as maintainer?
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
+BuildArch: ${RPM_ARCH}
+Packager: ${RPM_MAINTAINER}
+Vendor: Apache NetBeans
+Requires: java >= 11
+Recommends: ${RPM_RECOMMENDS}
+AutoReqProv: no
+
+%description
+${RPM_DESCRIPTION}
+
+%files
+%{_bindir}/netbeans
Review Comment:
Can't default to `netbeans` - needs to set the correct binary name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
