neilcsmith-net commented on code in PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#discussion_r1018105874
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
Review Comment:
> The more information, the better :)
In general, maybe. However, we need to provide options for any additional
fields - eg. `${RPM_LICENSE}` if needed. Although that might be better as a
global option as might be used elsewhere?
The DEB control file is just the minimum required to work well enough. User
can always override the whole template. However, anything specific to NetBeans
itself shouldn't be hardcoded. NBPackage is not intended just for packaging
NetBeans itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
