mbien commented on PR #4785:
URL: https://github.com/apache/netbeans/pull/4785#issuecomment-1307277525
> I'm not neutral about a green CI requirement for merging (once tests are
stable). That might be better achieved by a notice email and convention rather
than branch protection.
I probably misinterpreted something since I thought you suggested the green
checkmark requirement somewhere. But if you don't like that idea either - even
better - lets drop it from the list :)
> an infra ticket requirement would be a larger hurdle than necessary!
oh I didn't mean it like that. I meant that in an event we would be truly
locked out we could:
- simply push to master and turn that thing off
- if everything fails ask infra to turn it off again (but tbh I don't know
how we could end up that way)
I didn't mean to add infra to the process of merging a PR which has CI
failing.
But this is theoretical. Since given that we don't use
`pull_request_target`, I can't see right now how we could lock ourselves out.
So is force push protection to master something we all want or should I
close this whole PR since that would be the last open point as far as I see?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
