neilcsmith-net commented on PR #4785: URL: https://github.com/apache/netbeans/pull/4785#issuecomment-1307323013
> I probably misinterpreted something since I thought you suggested the green checkmark requirement somewhere. I'm in favour (with stable tests) of a general requirement for tests to be green before merging. We have had things merged in the past that were assumed to not be causes of test failures and turned out later to be a problem. So I don't entirely agree it's solving a problem we don't have. On the other hand, that's probably better solved by communication. The admin access UI to bypass branch protection (which afaik we don't have) [like shown here](https://stackoverflow.com/questions/73348721/github-branch-protection-disable-bypass) would be great IMO, but without that it's probably overkill, for now at least. Let's see how we do without it. I'm +1 to protecting against force push (then again, to an extent I'm in favour of disallowing direct push completely, as we've had things accidentally pushed before now). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
