eirikbakke commented on issue #4314: URL: https://github.com/apache/netbeans/issues/4314#issuecomment-1309095085
@tbw777 Could you enter the command "chcp" in the Windows Command Prompt, and let me know which "Active code page" number it prints? Thanks for your help! I think the warning dialog in the NetBeans launcher is testing the wrong thing; the problem occurs not when non-ASCII characters occur (c >= 128), but rather when the Win32 GetModuleFileName function returns a string with a question mark in it. The latter happens when there are characters in the path name that cannot be encoded in the system's default codepage (437 on my machine, which can encode certain non-ASCII characters such as the Norwegian æøå). So if the current Windows version is using e.g. a codepage that encodes Cyrillic script, path names with Cyrillic in them should work fine. But if you have Cyrillic script in a path on US Windows, it won't work. The correct solution would be to change the launcher script to use wchar_t instead of char when passing paths around, and use the corresponding wide-char Win32 functions everywhere (e.g. GetModuleFileNameW instead of GetModuleFileName). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
