lbownik commented on code in PR #5317:
URL: https://github.com/apache/netbeans/pull/5317#discussion_r1081240861
##########
harness/o.n.insane/src/org/netbeans/insane/impl/InsaneEngine.java:
##########
@@ -51,23 +52,23 @@ public InsaneEngine(Filter f, Visitor v, boolean
analyzeStatic) {
public InsaneEngine(ObjectMap backend, Filter f, Visitor v, boolean
analyzeStatic) {
objects = backend;
- filter = f == null ? ScannerUtils.noFilter() : f;
+ filter = (f != null ? f : ScannerUtils.noFilter());
visitor = v;
analyzeStaticData = analyzeStatic;
}
// normal set is enough, java.lang.Class have identity-based equals()
- private Set<Class> knownClasses = new HashSet<Class>();
+ private final Set<Class<?>> knownClasses = new HashSet<>();
// The queue for BFS scan of the heap.
// each thing, before added to the queue, is added
// to the known* structures and reported to the visitor
- private Queue<Object> queue = new Queue<Object>();
+ private final Queue<Object> queue = new Queue<>();
- public void traverse(Collection roots) throws Exception {
+ public void traverse(Collection<?> roots) throws Exception {
Review Comment:
reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
