lbownik commented on code in PR #5317:
URL: https://github.com/apache/netbeans/pull/5317#discussion_r1082399583
##########
harness/o.n.insane/src/org/netbeans/insane/model/BinaryHeapModel.java:
##########
@@ -49,7 +49,7 @@ public static HeapModel open(File file) throws Exception {
// mmap it
long len = data.length();
buffer = new
FileInputStream(data).getChannel().map(FileChannel.MapMode.READ_ONLY, 0, len);
- System.err.println("magic=" + buffer.getInt(0));
+ System.err.println("magic=" + buffer.getInt(0)); // shouldn't this be
replaced with logging statement?
Review Comment:
ha - but you spotted it and this was my intention :))))
the thing is that the whole module does not use Loggers but prints to
System.err - do You think it is a good oppotunity to employ loggin through
Loggger?
I'll remove this comment in the next commit enyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
