neilcsmith-net commented on code in PR #5352:
URL: https://github.com/apache/netbeans/pull/5352#discussion_r1087643842
##########
java/maven/nbproject/project.properties:
##########
@@ -22,7 +22,7 @@ javadoc.apichanges=${basedir}/apichanges.xml
javadoc.arch=${basedir}/arch.xml
javahelp.hs=maven.hs
extra.module.files=maven-nblib/
-spec.version.base: 2.156
+spec.version.base: 2.157
Review Comment:
As far as I can see, this should actually be?
`spec.version.base=2.157.0`
Use of colon means it gets skipped in increment task, and if not skipped
needs to end with `.0`? See
https://github.com/apache/netbeans/blob/master/nbbuild/antsrc/org/netbeans/nbbuild/IncrementSpecificationVersions.java#L96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists