neilcsmith-net commented on code in PR #5352:
URL: https://github.com/apache/netbeans/pull/5352#discussion_r1087754209
##########
java/maven/nbproject/project.properties:
##########
@@ -22,7 +22,7 @@ javadoc.apichanges=${basedir}/apichanges.xml
javadoc.arch=${basedir}/arch.xml
javahelp.hs=maven.hs
extra.module.files=maven-nblib/
-spec.version.base: 2.156
+spec.version.base: 2.157
Review Comment:
@sdedic yes, it's confusing! To get into NB17 it needs to be based on top
of `delivery`. Normally, spec versions are fixed from branch, because the
first thing we do on `master` at branch is a spec version increment (eg. #5312 )
However, the `maven` (and `java.editor.lib`) modules use a colon rather than
equals in the properties file, and are being missed out of that increment.
I've only just noticed that.
IMO, unless there's a reason those modules shouldn't be incrementing every
release, we should change this to what I suggested in my previous comment, and
keep your API comments as is, when rebasing on top of delivery.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
