lbownik commented on PR #5317: URL: https://github.com/apache/netbeans/pull/5317#issuecomment-1407445628
@vieiro > Good news! We'll wait for those tests them. Remember that we prefer _new_ tests, without modifying existing ones. The idea here is that new tests can replace existing ones later on, if needed. That will be easier to review for us. Ok. I will add comments to existing tests specifying which new tests obsolete them. > > The module does not mention any public packages in https://github.com/apache/netbeans/blob/master/harness/o.n.insane/nbproject/project.xml does it mean that it does not expose any APIs to other molecules or that every public class in all packages is exposed? > > Not all modules expose APIs to other modules, only if they have something interesting to expose to the world. This one exposes nothing. This module's properties mentions "Export packages onlly to friends" and mentions 3 packages. Does it mean that it is only used by these three mentioned packages? If so does it make sense to test only API calls that are actually used by those packages and maybe later remove all the unused code (code not covered by new tests)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
