neilcsmith-net commented on PR #5609: URL: https://github.com/apache/netbeans/pull/5609#issuecomment-1466045464
I share reservations of @mbien and @matthiasblaesing It's an interesting exercise, but could never be the default option, adds complexity to the build, and isn't really the best test of nb-javac IMO. Tests using modern language features and comparing output with the un-backported javac would seem more useful? Still, I'm -0 as long as it doesn't break things! > nb-javac is currently also not in this repository (or even an apache project unless I miss something obvious), so I am not sure what you mean by "eat your own dog food". Well, nb-javac is not an Apache NetBeans project, and _cannot_ be developed as an Apache NetBeans project*. Unless something significant changes in ASF rules, nb-javac is never going to be our "own dog food". Compiling NetBeans might be considered to be. Whichever, the responsibility for development and the bulk of testing nb-javac needs to remain external. If this change helps with testing _upstream_, it could go in. We could even consider running that build test in CI here, but I'd probably limit that to nb-javac update PRs. We don't have unlimited capacity. * one option to investigate, and discussed previously, might be running the backport javac build inside the NetBeans build, assuming no GPL+CPE sources required on our side. That would still need some checking with legal. > We should rather concentrate on upgrading everything to JDK 11 which actually solves problems and has likely community consensus as I gather from the last thread about it. @neilcsmith-net drafted a proposal for this. +1 to that, but I don't think there's any overlap in the two things. nb-javac cannot help with our requirements to update minimum JDK, and upgrading the base to JDK 11 then 17 won't remove our reliance on nb-javac for Java editing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
