jtulach commented on PR #5609: URL: https://github.com/apache/netbeans/pull/5609#issuecomment-1475124147
Thank you @neilcsmith-net: > Interesting exercise, ... adds complexity to the build, The complexity is fairly isolated into its own `NbJavacLoader` class. Beyond that there are just [three executable lines](https://github.com/apache/netbeans/pull/5609/files#diff-2e6575e0d5f99cfd495a77cb8c35ab906d34f9dd2ea1aa9c93156a180a237ab3R132) in `CustomJavac` task. I can refactor the `NbJavacLoader` to be a separate top level class, if that feels better. > and isn't really the best test of nb-javac IMO. Real project test is always a good test. In fact there are already two cases where the _"dog food test"_ helps `nb-javac` get better: - warnings that need to be addressed: https://github.com/apache/netbeans/pull/5609#discussion_r1141264240 - https://github.com/JaroslavTulach/nb-javac/pull/11 > If this change helps with testing upstream, it could go in. Yes, it does help. The testing is ready to go in: https://github.com/JaroslavTulach/nb-javac/pull/17 > We could even consider running that build test in CI here, Great, 7de1422 adds the GitHub Actions run and [it has succeeded](https://github.com/apache/netbeans/actions/runs/4459083199/jobs/7831316138). > but I'd probably limit that to nb-javac update PRs. We don't have unlimited capacity. OK, guidance to adjust 7de1422 welcomed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
