junichi11 commented on code in PR #5853:
URL: https://github.com/apache/netbeans/pull/5853#discussion_r1172417641
##########
php/php.phpunit/src/org/netbeans/modules/php/phpunit/commands/PhpUnit.java:
##########
@@ -406,7 +407,12 @@ private TestParams getTestParams(PhpModule phpModule,
TestRunInfo runInfo) throw
// standard suite
// #218607 - hotfix
//params.add(SUITE_NAME)
- params.add(getNbSuite().getAbsolutePath());
+ if (PhpUnitPreferences.getPhpUnitVersion(phpModule) ==
PhpUnitVersion.PHP_UNIT_9) {
+ params.add(getNbSuite().getAbsolutePath());
+ } else {
+ // GH-5790 we can use NetBeansSuite.php no longer with
PHPUnit 10
+
params.add(FileUtil.toFile(startFiles.get(0)).getAbsolutePath());
Review Comment:
Yes, you are right. However, I'm not sure the way to run multiple files...
We could do it via `NetBeansSuite.php`, so far, right?
```
php vendor/bin/phpunit --help
PHPUnit 10.1.1 by Sebastian Bergmann and contributors.
Usage:
phpunit [options] UnitTest.php
phpunit [options] <directory>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
