tmysik commented on code in PR #5853:
URL: https://github.com/apache/netbeans/pull/5853#discussion_r1172439494
##########
php/php.phpunit/src/org/netbeans/modules/php/phpunit/commands/PhpUnit.java:
##########
@@ -406,7 +407,12 @@ private TestParams getTestParams(PhpModule phpModule,
TestRunInfo runInfo) throw
// standard suite
// #218607 - hotfix
//params.add(SUITE_NAME)
- params.add(getNbSuite().getAbsolutePath());
+ if (PhpUnitPreferences.getPhpUnitVersion(phpModule) ==
PhpUnitVersion.PHP_UNIT_9) {
+ params.add(getNbSuite().getAbsolutePath());
+ } else {
+ // GH-5790 we can use NetBeansSuite.php no longer with
PHPUnit 10
+
params.add(FileUtil.toFile(startFiles.get(0)).getAbsolutePath());
Review Comment:
Exactly. This is the reason why we had to use `NetBeansSuite.php`. I am
afraid we need to investigate how/whether this is supported in PHPUnit now...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
