mbien commented on code in PR #6665:
URL: https://github.com/apache/netbeans/pull/6665#discussion_r1385455051
##########
php/php.editor/src/org/netbeans/modules/php/editor/csl/FoldingScanner.java:
##########
@@ -179,7 +179,7 @@ public Map<String, List<OffsetRange>> folds(ParserResult
info) {
program.accept(new FoldingVisitor(folds));
Source source = phpParseResult.getSnapshot().getSource();
assert source != null : "source was null";
- Document doc = source.getDocument(false);
+ Document doc = source.getDocument(true);
Review Comment:
@junichi11 would be good to observe this to check if it causes any
performance issues.
It could be worth checking how often `source.getDocument(false)` would be
null here during regular project development. If its very often the case, we
could try to solve this differently (e.g bullet point 1 of the PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
