mbien commented on code in PR #6665:
URL: https://github.com/apache/netbeans/pull/6665#discussion_r1385746629
##########
php/php.editor/src/org/netbeans/modules/php/editor/csl/FoldingScanner.java:
##########
@@ -179,7 +179,7 @@ public Map<String, List<OffsetRange>> folds(ParserResult
info) {
program.accept(new FoldingVisitor(folds));
Source source = phpParseResult.getSnapshot().getSource();
assert source != null : "source was null";
- Document doc = source.getDocument(false);
+ Document doc = source.getDocument(true);
Review Comment:
yes but making the program aware of the test is always a bit ugly. The
program should, if possible, never know that it is tested so that the results
are the same as in real world. This is also a valid option but I would try to
use it only if we really have to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
