lahodaj opened a new pull request, #6743:
URL: https://github.com/apache/netbeans/pull/6743
Currently, `libs.nbjavacapi` (which is a module fragment for
`libs.javacapi`) cannot be simply deactivated, it must be uninstalled to be
really not used.
This patch is attempting to fix that, by:
a) following enabled/disabled for module fragments (rather then using them
regardless of their status)
b) tweaking (or fixing) `ModuleManager.simulateEnable` to not fail if the
fragment host is already enabled (so that the list of modules to enable is
available). `enable` will fail, of course, if the fragment host is already
enabled. This is needed so that the UI can check which modules would be
enabled, and force a restart if/as needed.
c) tweaking the UI so that it can force a restart also when enabling modules
(it already does that when disabling modules). Sadly, this requires quite a few
changes, including adding a new on-disk file for the enable list.
As this adds a `to_enable.txt` file, this will also need a change in the
Window launchers. Alternatively, we could re-purpose the `to_disable.txt` file,
by using it also for module enablement (which could be done e.g. creating
sections in that file).
Please let me know what you think. I am not that much expert on the module
system. Thanks!
---
**^Add meaningful description above**
By opening a pull request you confirm that, unless explicitly stated
otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache
License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and
email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more
information.
If you're a committer, please label the PR before pressing "Create pull
request" so that the right test jobs can run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
