sdedic commented on code in PR #6743:
URL: https://github.com/apache/netbeans/pull/6743#discussion_r1429281715
##########
platform/autoupdate.services/libsrc/org/netbeans/updater/UpdaterDispatcher.java:
##########
@@ -60,7 +61,12 @@ private void dispatch () {
// then disable
if (isDisableScheduled ()) {
- new ModuleDeactivator(context).disable();
+ new ModuleDeactivator(context).enableDisable(false);
+ }
+
+ // then disable
Review Comment:
Nitpick^2: -> then enable
##########
platform/autoupdate.services/libsrc/org/netbeans/updater/ModuleDeactivator.java:
##########
@@ -87,6 +91,11 @@ public static boolean hasModulesForDisable (File updateDir) {
return deactivateDir.exists () && deactivateDir.isDirectory () &&
Arrays.asList (deactivateDir.list ()).contains (TO_DISABLE);
}
+ public static boolean hasModulesForEnable (File updateDir) {
+ File deactivateDir = new File (updateDir,
UpdaterDispatcher.DEACTIVATE_DIR);
Review Comment:
Nitpick: having _enable_ file in `deactivate` directory is a bit awkward...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
