matthiasblaesing commented on code in PR #7567: URL: https://github.com/apache/netbeans/pull/7567#discussion_r1676538853
########## enterprise/web.jspparser/external/binaries-list: ########## @@ -19,3 +19,6 @@ F48473482C0E3E714F87186D9305BCAE30B7F5CB org.glassfish:jakarta.el:3.0.4 9A3D933B7B079AD73C43878BF09AC47586FAC897 org.glassfish.main.common:glassfish-ee-api:5.1.0 CED8804F81DB0C9099786472C615A12EA592C44B org.glassfish.main.common:common-util:5.1.0 +34A035507F0270F1C6B7722D728BD7B5A9BBAC4C jakarta.servlet.jsp.jstl:jakarta.servlet.jsp.jstl-api:1.2.7 +F5A092DE3B2B087C14CA4B8D6F2C77A1F6802828 org.glassfish.web:jakarta.servlet.jsp.jstl:1.2.6 +8CFF7DC1E492911F3DD7640EBFB60D6206A1DD40 commons-logging:commons-logging:1.3.1 Review Comment: > We also made some efforts to deduplicate and sync up all asm users which worked well. I'm a bit fuzzy, but if I remember correctly, in this case asm was used at runtime. That is a totally different case then the usage here for sample projects. >IMO: lib wrapper update PRs for commonly used libs should always run all tests - so its caught right away. (e.g I ran all tests for flatlaf once https://github.com/apache/netbeans/pull/7565) a) we have tests, that are partially deactivated b) we have tests that don't run at all at CI/CD time So no. It won't be caught. Case in point: This PR reenables unittests which bitrottet. >can you add a comment to the binaries-list file that this is test data and updates should be ignored? https://github.com/apache/netbeans/blob/c7e9bada8d0c41c30545962085e53ca38ad3414d/nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-overlaps#L125 https://github.com/apache/netbeans/blob/c7e9bada8d0c41c30545962085e53ca38ad3414d/enterprise/web.jspparser/external/jakarta.servlet.jsp.jstl-1.2-license.txt#L7 https://github.com/apache/netbeans/blob/c7e9bada8d0c41c30545962085e53ca38ad3414d/enterprise/web.jspparser/external/commons-logging-1.3.1-license.txt#L7 From my perspective this is a total non-issue. I have some hopes, that nobody run around blindly updating binaries without checking what the module does with these. If I remember correctly the jstl binaries are even from the JavaEE area and thus will never seen an update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
