lkishalmi commented on code in PR #7567:
URL: https://github.com/apache/netbeans/pull/7567#discussion_r1676981780
##########
enterprise/web.jspparser/extsrc/org/netbeans/modules/web/jspparser_ext/WebAppParseSupport.java:
##########
@@ -416,21 +386,18 @@ private synchronized JspCompilationContext
createCompilationContext(FileObject j
} else {
clctxt = new JspCompilationContext(jspUri, false, options,
context, null, rctxt);
}
+ clctxt.setClassLoader(getWAClassLoader());
} catch (JasperException ex) {
LOG.log(Level.INFO, null, ex);
}
- clctxt.setClassLoader(getWAClassLoader());
return clctxt;
}
boolean determineIsTagFile(FileObject fo) {
if (fo.getExt().startsWith("tag")) { // NOI18N - all tag, tagx and
even tagf are considered tag files
return true;
}
- if (JspParserAPI.TAG_MIME_TYPE.equals(fo.getMIMEType())) {
- return true;
- }
- return false;
+ return JspParserAPI.TAG_MIME_TYPE.equals(fo.getMIMEType());
Review Comment:
Could tally with the previous `fo.getExt` condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
