lahodaj commented on code in PR #7776: URL: https://github.com/apache/netbeans/pull/7776#discussion_r1776478699
########## java/java.file.launcher/src/org/netbeans/modules/java/file/launcher/Bundle.properties: ########## @@ -16,3 +16,6 @@ # under the License. OpenIDE-Module-Name=Java File Launcher +GlobalSettingsPanel.vmLabel.text=VM Options: Review Comment: Note that the source launcher does not produce any (on-disk) classfiles, at least as far as I know. And `--source` is no longer mandatory for source launcher, so `--enable-preview` is sufficient. I think this significantly reduces possibility of bigger trouble. And I think simple `--enable-preview` should work also for nb-javac, at least to the degree preview can work with nb-javac. Overall, I don't think the danger with having some global setting is so big. We have global settings for both Maven and Ant, and if I put something wrong there, I may get weird results. What may be not-ideal is that one cannot easily see the effective command line (i.e. global + per-file VM options). It might make sense to add a new read-only property to the properties view showing the effective/full command line. Shouldn't be too difficult (I hope), see here: https://github.com/apache/netbeans/blob/cd0213d9cbd2e1c6c00cbaf11c4fd48d5ff93e61/java/java.source/src/org/netbeans/modules/java/JavaNode.java#L247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
