mbien commented on code in PR #7776: URL: https://github.com/apache/netbeans/pull/7776#discussion_r1776871360
########## java/java.file.launcher/src/org/netbeans/modules/java/file/launcher/Bundle.properties: ########## @@ -16,3 +16,6 @@ # under the License. OpenIDE-Module-Name=Java File Launcher +GlobalSettingsPanel.vmLabel.text=VM Options: Review Comment: > We have global settings for both Maven and Ant, and if I put something wrong there, I may get weird results. Yes of course but that is the reason I asked for the use case. The difference here is that the preview flag influences build and runtime of all project-less programs, while the maven flags for example are for the maven tooling JVM (-X etc). There isn't really a use case for enabling preview for maven tooling unless for very specific tasks like testing a plugin or something like that. But the java launcher doesn't even understand `-Xlint`, so the global args are super limited here! I like the idea of showing the global args field in the file properties. The output could also print the exec line analog how maven support does it - but this doesn't have to be all implemented in the same PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
