mbien commented on code in PR #7930:
URL: https://github.com/apache/netbeans/pull/7930#discussion_r1924355888
##########
platform/core.multitabs/src/org/netbeans/core/multitabs/impl/FolderNameTabDecorator.java:
##########
@@ -54,10 +79,14 @@ public String getText( TabData tab ) {
if( fo.isData() ) {
FileObject folder = fo.getParent();
if( null != folder ) {
- String folderName = folder.getNameExt() +
pathSeparator;
- String defaultText = tab.getText();
-
- return merge( folderName, defaultText );
+ String folderName = folder.getNameExt() +
File.separator;
+ // don't use faded colors in tabs when colored tabs
are active
+ // since it is difficult to get right with so many
colors and shades involved
+ // the switcher uses a line as marker instead of bg
change and can continue using fade colors
+ if (!(isTab && settings.isSameProjectSameColor())) {
+ folderName = "<font color=\"" + fadeColor + "\">"
+ folderName + "</font>"; //NOI18N
+ }
+ return merge(folderName, tab.getText());
Review Comment:
the path decoration will now disable itself on tabs if colored tabs are
active, the switcher will keep using the faded color since its colored tabs
impl is different
an attempt to fix some contrast problems mentioned in
https://github.com/apache/netbeans/pull/7930#issuecomment-2594268630 is pending
at https://github.com/apache/netbeans/pull/8175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
