neilcsmith-net commented on PR #7930: URL: https://github.com/apache/netbeans/pull/7930#issuecomment-2610038500
> @neilcsmith-net Your main objection is with the fadeColor method that has a hard-coded alpha value in it, right? No, my main objection is that the faded colour is not coming from a UI key (ideally a shared one), probably with a suitable fallback to an existing key. That could be looked at for NB 26. I have a whole bunch of similar blending code functions I could contribute. But so does FlatLaf, and I firmly believe this belongs in the LaF configuration. LaFs without overridable accent colours, etc. can have a fixed value / use an existing key anyway. Think separation of concerns like HTML and CSS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
