mbien commented on code in PR #8194:
URL: https://github.com/apache/netbeans/pull/8194#discussion_r1929834990
##########
enterprise/web.monitor/src/org/netbeans/modules/web/monitor/client/TransactionView.java:
##########
@@ -310,8 +310,8 @@ public void actionPerformed(ActionEvent e) {
}
}});
- timeDButton = new JToggleButton(new ImageIcon(
-
TransactionView.class.getResource("/org/netbeans/modules/web/monitor/client/icons/timesortB.gif")),
true);
+ timeDButton = new JToggleButton(ImageUtilities.loadIcon(
+
"org/netbeans/modules/web/monitor/client/icons/timesortB.gif"), true);
Review Comment:
tbh I am glad that not everything calls through the localized code paths,
since it is one cache indirection more.
I have a ImageUtilities in my stash with some cleanups since I planned to
update it to CHM but wanted to simplify it first before making that change. Now
that everything calls into it it might be worth to try to get rid of the
synchronized blocks. Although most of it might load icons on EDT - I do expect
some of it happening during classloading - something to verify firs - if true -
CHM might be worth it.
(also one day in future: we might even want to prefetch hot icons from a
single resource module on startup)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
