mbien commented on code in PR #8194:
URL: https://github.com/apache/netbeans/pull/8194#discussion_r1931599731
##########
enterprise/web.monitor/src/org/netbeans/modules/web/monitor/client/TransactionView.java:
##########
@@ -310,8 +310,8 @@ public void actionPerformed(ActionEvent e) {
}
}});
- timeDButton = new JToggleButton(new ImageIcon(
-
TransactionView.class.getResource("/org/netbeans/modules/web/monitor/client/icons/timesortB.gif")),
true);
+ timeDButton = new JToggleButton(ImageUtilities.loadIcon(
+
"org/netbeans/modules/web/monitor/client/icons/timesortB.gif"), true);
Review Comment:
mostly EDT as of today:
```
7465 thread: Thread[AWT-EventQueue-0,6,IDE Main]
324 thread: Thread[Folder Instance Processor,1,system]
29 thread: Thread[main,5,IDE Main]
16 thread: Thread[Warm Up,1,system]
4 thread:
Thread[org.netbeans.modules.web.clientproject.browser.ActiveBrowserAction,1,system]
```
removing the critical section wouldn't change much at the moment.
another metric: about 450ms is spent for loading icons during startup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
