eirikbakke commented on code in PR #8194:
URL: https://github.com/apache/netbeans/pull/8194#discussion_r1932637960
##########
enterprise/web.monitor/src/org/netbeans/modules/web/monitor/client/TransactionView.java:
##########
@@ -310,8 +310,8 @@ public void actionPerformed(ActionEvent e) {
}
}});
- timeDButton = new JToggleButton(new ImageIcon(
-
TransactionView.class.getResource("/org/netbeans/modules/web/monitor/client/icons/timesortB.gif")),
true);
+ timeDButton = new JToggleButton(ImageUtilities.loadIcon(
+
"org/netbeans/modules/web/monitor/client/icons/timesortB.gif"), true);
Review Comment:
@neilcsmith-net Yeah, "localized" is just what the logic is called in
ImageUtilities code. But it's also the pressed/rollover/disabled variations of
each action icon being checked for. E.g., here are all the non-existent
variations that are attempted to be loaded (_excluding_ SVG extensions, that's
another 2x calls!) for a single icon:
```
org/netbeans/modules/editor/bookmarks/resources/bookmark_16_nb_en_US.png
org/netbeans/modules/editor/bookmarks/resources/bookmark_16_nb_en.png
org/netbeans/modules/editor/bookmarks/resources/bookmark_16_nb.png
org/netbeans/modules/editor/bookmarks/resources/bookmark_16_en_US.png
org/netbeans/modules/editor/bookmarks/resources/bookmark_16_en.png
org/netbeans/modules/editor/bookmarks/resources/bookmark_16_pressed_nb_en_US.png
org/netbeans/modules/editor/bookmarks/resources/bookmark_16_pressed_nb_en.png
org/netbeans/modules/editor/bookmarks/resources/bookmark_16_pressed_nb.png
org/netbeans/modules/editor/bookmarks/resources/bookmark_16_pressed_en_US.png
org/netbeans/modules/editor/bookmarks/resources/bookmark_16_pressed_en.png
org/netbeans/modules/editor/bookmarks/resources/bookmark_16_pressed.png
org/netbeans/modules/editor/bookmarks/resources/bookmark_16_rollover_nb_en_US.png
org/netbeans/modules/editor/bookmarks/resources/bookmark_16_rollover_nb_en.png
org/netbeans/modules/editor/bookmarks/resources/bookmark_16_rollover_nb.png
org/netbeans/modules/editor/bookmarks/resources/bookmark_16_rollover_en_US.png
org/netbeans/modules/editor/bookmarks/resources/bookmark_16_rollover_en.png
org/netbeans/modules/editor/bookmarks/resources/bookmark_16_rollover.png
org/netbeans/modules/editor/bookmarks/resources/bookmark_16_disabled_nb_en_US.png
org/netbeans/modules/editor/bookmarks/resources/bookmark_16_disabled_nb_en.png
org/netbeans/modules/editor/bookmarks/resources/bookmark_16_disabled_nb.png
org/netbeans/modules/editor/bookmarks/resources/bookmark_16_disabled_en_US.png
org/netbeans/modules/editor/bookmarks/resources/bookmark_16_disabled_en.png
org/netbeans/modules/editor/bookmarks/resources/bookmark_16_disabled.png
```
I guess we have a combinatorial explosion... (with and without SVG extension
= 2) * (4 action button states) * (6 branding/localization suffix combinations)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
