neilcsmith-net commented on code in PR #8318:
URL: https://github.com/apache/netbeans/pull/8318#discussion_r1991144113
##########
platform/o.n.core/src/org/netbeans/core/actions/LogViewerSupport.java:
##########
@@ -103,7 +105,20 @@ public void run() {
}catch (IOException e) {
Logger.getLogger(LogViewerSupport.class.getName()).log(Level.INFO, null, e);
}
- task.schedule(10000);
+ /* If the user closes the entire Output pane, rather than the
specific IDE Log tab
+ within the Output pane, the InputOutput will not actually end up
being closed. Detect
+ this situation and close the InputOutput explicitly in this case.
*/
+ SwingUtilities.invokeLater(() -> {
Review Comment:
I really don't like this code. The fix is in the wrong place, if it needs
fixing at all?!
The updates could possibly be based on activation? A shame that the IO
callbacks are lacking visibility calls, but could be added?
Part of the problem is the UI behaviour of the Output window when a single
tab is open which makes it hard to close the log when shown alone? If you
close Output with only a single tab, should it explicitly close the tab???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
