neilcsmith-net commented on code in PR #8318:
URL: https://github.com/apache/netbeans/pull/8318#discussion_r1991520086
##########
platform/o.n.core/src/org/netbeans/core/actions/LogViewerSupport.java:
##########
@@ -103,7 +105,20 @@ public void run() {
}catch (IOException e) {
Logger.getLogger(LogViewerSupport.class.getName()).log(Level.INFO, null, e);
}
- task.schedule(10000);
+ /* If the user closes the entire Output pane, rather than the
specific IDE Log tab
+ within the Output pane, the InputOutput will not actually end up
being closed. Detect
+ this situation and close the InputOutput explicitly in this case.
*/
+ SwingUtilities.invokeLater(() -> {
Review Comment:
> It's ugly, but I do think it needs fixing, as it's a case where a worker
thread would be started and never stopped.
`RequestProcessor` not worker thread. The problem isn't necessarily major,
although it would be nice to fix.
> Probably not, because if the user then clicks Window->Output to reopen the
Output pane, the tabs should remain the way they were. Or not?
Agreed. Which is part of my issue with your fix, because you're breaking
that behaviour for one tab(?) The counter problem is that the single tab UI
behaviour makes it impossible to close just the last tab. Actually, not
impossible, you can right-click and close from the menu, but it's not exactly
intuitive! To the user, it looks like you're closing the last tab when you're
not.
> Probably not "activation" in the sense of "focus", because one should be
able to keep seeing the log update even if focus is elsewhere. Visibility is
another option, though.
Yes, that's what I meant. Could possibly consider visibility callbacks
added as default no-ops in
https://github.com/apache/netbeans/blob/master/platform/openide.io/src/org/openide/windows/IOContainer.java#L307
? Could then be triggered by standard TopComponent showing / hidden behaviour?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
